Opened 5 years ago
#199 new Defect
gridcheck: checking array dimensions needs to be improved
Reported by: | pesei | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | FLEXPART 10 |
Component: | FP coding/compilation | Version: | FLEXPART 10.2 |
Keywords: | Cc: |
Description
In gridcheck*.f90, there is a check whether the array dimension for the met input as defined in par_mod.f90 are sufficient for the data being read. However, the check comes after data have been assigned to arrays. This means that array boundary violations will still occur, even if FLEXPART is terminated soon after.
In v10, a copy of the x-dimension check has been placed at an earlier location. However, the other dimensions are still not properly checked, and in gridcheck_gfs.f90 even this has not been done (so running the code with -fcheck=all, I received an error message - that is how I discovered the problem).
Note: See
TracTickets for help on using
tickets.