#197 closed Defect (fixed)

Inconsistent use of ew in verttransform

Reported by: adingwell Owned by: pesei
Priority: major Milestone: FLEXPART 10
Component: FP coding/compilation Version: FLEXPART 10.0
Keywords: Cc:

Description (last modified by pesei)

I found that ew is not properly initialized in verttransform.f90

These are all the occurrences of ew in each of the verttransform*-files:

verttransform.f90:

real :: ew,dz1,dz2,dz
...
tvold(ixm,jym)=tt2(ixm,jym,1,n)*(1.+0.378*ew*(td2(ixm,jym,1,n))/ &
     ps(ixm,jym,1,n))
...
tvold(ix,jy)=tt2(ix,jy,1,n)*(1.+0.378*ew(td2(ix,jy,1,n))/ &
     ps(ix,jy,1,n))

verttransform_gfs.f90:

real :: ew,pint,tv,tvold,pold,dz1,dz2,dz,ui,vi
...
tvold=tt2(ixm,jym,1,n)*(1.+0.378*ew(td2(ixm,jym,1,n))/ &
     ps(ixm,jym,1,n))

verttransform_nests.f90:

real :: ew,dz1,dz2,dz
...
tvold(ix,jy)=tt2n(ix,jy,1,n,l)*(1.+0.378*ew*(td2n(ix,jy,1,n,l))/ &
     psn(ix,jy,1,n,l))

Notice that in verttransform.f90 ew is used as a variable, not a function. This variable is defined but not initialized.

Change History (3)

comment:1 Changed 13 months ago by adingwell

  • Description modified (diff)

comment:2 Changed 12 months ago by pesei

  • Description modified (diff)
  • Owner set to pesei
  • Status changed from new to accepted
  • Summary changed from Inconsistent use of ew in vertransform* to Inconsistent use of ew in verttransform

I confirm this bug. It is already fixed by v10 developers in the later versions. Please note that v10 is not released yet (cf. https://www.flexpart.eu/wiki/FpRoadmap). Probably not a good idea to offer this in the download section, so I propose to remove it.

comment:3 Changed 12 months ago by pesei

  • Resolution set to fixed
  • Status changed from accepted to closed

Download has been delelted. If someone wants to try out v10 (which is beta!) use git!

Note: See TracTickets for help on using tickets.
hosted by ZAMG