Opened 5 years ago

Last modified 3 years ago

#101 accepted Task

Code review for changeset 31 / hasod

Reported by: hasod Owned by: pesei
Priority: major Milestone: FLEXPART 9.2
Component: FP coding/compilation Version: FLEXPART 9.2 beta
Keywords: Cc:

Description

New feature netcdf output added. Affected routines are FLEXPART.f90, com_mod.f90, netcdf_output_mod.f90, readcommand.f90, timemanager.f90.

Someone should test compilation and output on another system setup in addition to hasod.

Change History (6)

comment:1 Changed 5 years ago by hasod

  • Owner changed from somebody to hasod
  • Status changed from new to assigned

comment:2 Changed 5 years ago by hasod

Update: the -cpp compiler flag now always needs to be specified, such that conditional compilation works

comment:3 Changed 5 years ago by hasod

  • Summary changed from Code review for changeset 30 / hasod to Code review for changeset 31 / hasod

Update: added the missing source code netcdf_module.f90, change to Rev. 31. Please review Rev. 31 instead.

comment:4 Changed 5 years ago by pesei

  • Owner changed from hasod to pesei
  • Status changed from assigned to accepted

I'll try do at least some testing & review (missing netcdf_module.f90 was first result ...)

comment:5 Changed 5 years ago by pesei

See also #94 Code review for changeset:27 ! I suggest the present changeset:30 be reviewed together with all since 27.

comment:6 Changed 3 years ago by adingwell

I did some tests on the systems I have access to and get it to work with little effort. But I have some comments:

  • The height variable is a bit ambiguous and could use a description attribute which clarifies that it represents the top of cells.
  • I don't think it's recommended to put the unlimited dimension in the middle. If I recall correctly, this wasn't possible prior to netcdf4. The main reason it is allowed now (I think) is to accommodate for multiple unlimited dimensions when needed. It's more common to assign it as the first dimension (i.e. as the last dimension in Fortran); doing so would ensure that it works with most applications, including ncview.

I have little experience with the default output format so I haven't made any comparison between the two.

Note: See TracTickets for help on using tickets.
hosted by ZAMG