readwind_gfs() not reading total cloud cover from GRIB2

[donaldjmorton]

In trying to resolve wet deposition differences between FP9.02 and our Vtable version of FP, I stumbled with GRIB parameter codes for total cloud cover. As I see it, the codes used in readwind_gfs() are incorrect for GRIB2 inputs. My initial debugging consisted of printing SUM(tcc) at each timestep, and it was always 0.0.

So then I looked at the code, and it never even checks GRIB2 parameters for TCC. It only checks for GRIB1 parameters of 071 with level type of 244. I even put print statements in all the "if" blocks that deal with TCC, and not one of them printed.

We have created Vtable code which resolves this kind of problem, but if anybody wants to resolve the issue in existing FP9.02 code, I recommend adding the following in readwind_gfs(), in the section of code that converts GRIB2 codes to GRIB1 codes (for use further down in the routine).

  elseif ((parCat.eq.6).and.(parNum.eq.1).and.(typSurf.eq.244)) then ! TCC
    isec1(6)=71          ! indicatorOfParameter
    isec1(7)=244         ! indicatorOfTypeOfLevel

After doing this, I am finding identical output between our FP with Vtables and the original FP9.02.

[pesei]

should be put into Fp9.2, thanks!