Custom Query (210 matches)

The files created by write_ncconc.f90 aren't closed unless the maximum number of records per file is reached. This leads to a lot of memory being wasted when making repeated runs (without any external means of cleaning out dead memory).

It can be fixed by putting the following lines at the end of write_ncconc.f90:

  if ( jul .ge. edate ) then
    write(*,*) "write_ncconc: End of simulation reached, closing output file"
    ncret=nf_close(ncid)
    call check_ncerror(ncret)
  endif

I've tried running FLEXPART-WRF with Mercator projection and got the error:

need orientation longitude (stdlon) as: 
   -180e <= lon1 <= 180w
STOP map_init

This error should not occur if Mercator projection is used. The problem is in the subroutine map_set. The variable 'proj_merc' is referenced before it is defined. I've marked the changes needed to fix the problem below:

      proj_code = proj_code_in
      
      !!! This is where map_init should be called to fix the problem
      call map_init

      ! first, check for validity of mandatory variables in proj
      if ( abs(lat1) .gt. 90.001 ) then
        print '(a)', 'latitude of origin corner required as follows:'
        print '(a)', '    -90n <= lat1 < = 90.n'
        stop 'map_init'
      endif
      if ( abs(lon1) .gt. 180.) then
        print '(a)', 'longitude of origin required as follows:'
        print '(a)', '   -180e <= lon1 <= 180w'
        stop 'map_init'
      endif
      if ((dx .le. 0.).and.(proj_code .ne. proj_latlon)) then
        print '(a)', 'require grid spacing (dx) in meters be positive!'
        stop 'map_init'
      endif
      if ((abs(stdlon) .gt. 180.).and.(proj_code .ne. proj_merc)) then
        print '(a,i3)', 'proj_code: ', proj_code
        print '(a,i3)', 'proj_merc: ', proj_merc
        print '(a)', 'need orientation longitude (stdlon) as: '
        print '(a)', '   -180e <= lon1 <= 180w'
        stop 'map_init'
      endif
      if (abs(truelat1).gt.90.) then
        print '(a)', 'set true latitude 1 for all projections!'
        stop 'map_init'
      endif

      !!! This is where "map_init" is called in 3.2 BETA

It's also rather confusing when the stop code is 'map_init' but the problem occurs in the subroutine 'map_set'.

SFC_OPTION currently only has one valid choice (0). Setting SFC_OPTION=1 (WRF) either does nothing or causes crashes (see ticket #158), I suggest keeping the option for possible future use, but adding an error message if bad values are given.