Opened 4 years ago

Last modified 11 months ago

#270 accepted Defect

readreceptors.f90: bug in namelist version

Reported by: pesei Owned by: pesei
Priority: major Milestone: FLEXPART 11
Component: FP coding/compilation Version: FLEXPART 10.4
Keywords: Cc: igpis

Description

The reading of the namelist version of RECEPTORS is not properly implemented. The first record is read to test whether the file is namelist. If it is, this record is discarded, thus the first receptor is not used.

Change History (3)

comment:1 Changed 4 years ago by pesei

  • Status changed from new to accepted

comment:2 Changed 11 months ago by pesei

From my 2015 code review:

readreceptors: strange condition

      if ((x.eq.0.).and.(y.eq.0.).and. &
           (receptor.eq.'                ')) then
        j=j-1
        goto 100
      endif

maybe its even a bug as we have numrec=j-1 later
there is code redundancy in reading receptors

Version 1, edited 11 months ago by pesei (previous) (next) (diff)

comment:3 Changed 11 months ago by pesei

  • Milestone changed from FLEXPART 10 to FLEXPART 11
Note: See TracTickets for help on using tickets.
hosted by ZAMG