Compilation error with Intel Fortran

[ahilboll]

When trying to compile the release-10 branch with Intel ifort, I get the error

ifort -c -I/opt/software/eb/software/ecCodes/2.12.5-iimpi-2019a/include -I/opt/software/eb/software/netCDF-Fortran/4.4.5-iimpi-2019a/include -O3  -g -fpp -fp-model source -mcmodel=medium -unroll -ipo -inline -heap-arrays 32 -xHost -traceback assignland.f90
concoutput_inversion.f90(357): error #6503: This keyword is invalid for this intrinsic procedure reference.   [UNIT]
            call flush(unit=unitrelnames)
-----------------------^
compilation aborted for concoutput_inversion.f90 (code 1)
make: *** [concoutput_inversion.o] Fehler 1

Compilation succeeds when I remove the call from that line, as shown in this patch:

diff --git a/src/concoutput_inversion.f90 b/src/concoutput_inversion.f90
index fb327cf..9562bd2 100644
--- a/src/concoutput_inversion.f90
+++ b/src/concoutput_inversion.f90
@@ -354,7 +354,7 @@ subroutine concoutput_inversion(itime,outnum,gridtotalunc,wetgridtotalunc, &
             open(unit=unitrelnames, file=path(2)(1:length(2))//'releases_out',form='formatted', &
                  & access='APPEND', iostat=ierr)
             write(unitrelnames,'(a)') areldate//areltime//'_'//anspec
-            call flush(unit=unitrelnames)
+            flush(unit=unitrelnames)
             close(unitrelnames)
           endif
         endif

After checking ​https://gcc.gnu.org/onlinedocs/gcc-9.2.0/gfortran/FLUSH.html, it seems that recent Fortran compilers don't need the call any more. And indeed, on our system (gfortran 6.3.0) the modified code compiles as well.

So I suggest to apply the above patch.

[pesei]

My first impression is that flush is not needed at all. But I have never studied Rona's code and I am not certain.

[ignacio]

The flush statement was removed in commit 10bfff9