Changeset ff99eae in flex_extract.git for python/test_suite.py

Timestamp:

Jun 1, 2018, 8:34:59 PM (6 years ago)

Author:

Anne Philipp <anne.philipp@…>

Branches:

master, ctbto, dev

Children:

e1228f3

Parents:

ccab809

Message:

completed application of pep8 style guide and pylint investigations. added documentation almost everywhere

File:

• python/test_suite.py (moved) (moved from python/testsuite.py) (8 diffs)

python/test_suite.py

@@ -2 +2 @@
 # -*- coding: utf-8 -*-
 #************************************************************************
-# TODO AP
-#
+# ToDo AP
 # - provide more tests
 # - provide more documentation
-# -
 #************************************************************************
 
@@ -28 +26 @@
 # @Program Functionality:
 #    This script triggers the ECMWFDATA test suite. Call with
-#    testsuite.py [test group]
+#    test_suite.py [test group]
 #
 # @Program Content:
@@ -46 +44 @@
 # ------------------------------------------------------------------------------
 try:
-    taskfile = open('testsuite.json')
-except:
-    print 'could not open suite definition file testsuite.json'
+    taskfile = open('test_suite.json')
+except IOError:
+    print 'could not open suite definition file test_suite.json'
     exit()
 
@@ -73 +71 @@
     try:
         tk, tv = g, tasks[g]
-    except:
-        continue
+    finally:
+        pass
     garglist = []
     for ttk, ttv in tv.iteritems():
@@ -80 +78 @@
             if ttk != 'script':
                 garglist.append('--' + ttk)
-                if '$' == ttv[0]:
+                if ttv[0] == '$':
                     garglist.append(os.path.expandvars(ttv))
                 else:
@@ -89 +87 @@
             for tttk, tttv in ttv.iteritems():
                 if isinstance(tttv, basestring):
-                        arglist.append('--' + tttk)
-                        if '$' in tttv[0]:
-                            arglist.append(os.path.expandvars(tttv))
-                        else:
-                            arglist.append(tttv)
+                    arglist.append('--' + tttk)
+                    if '$' in tttv[0]:
+                        arglist.append(os.path.expandvars(tttv))
+                    else:
+                        arglist.append(tttv)
             print 'Command: ', ' '.join([tv['script']] + garglist + arglist)
             o = '../test/' + tk + '_' + ttk + '_' + '_'.join(ttv.keys())
@@ -101 +99 @@
                 p = subprocess.check_call([tv['script']] + garglist + arglist,
                                           stdout=f, stderr=f)
-            except:
+            except subprocess.CalledProcessError as e:
                 f.write('\nFAILED\n')
                 print 'FAILED'
@@ -111 +109 @@
 print str(jobcounter-jobfailed) + ' successful, ' + str(jobfailed) + ' failed'
 print 'If tasks have been submitted via ECACCESS please check emails'
-
-#print tasks