Changeset 4971f63 in flex_extract.git for source/python

Timestamp:

Sep 27, 2018, 12:31:47 PM (6 years ago)

Author:

Anne Philipp <anne.philipp@…>

Branches:

master, ctbto, dev

Children:

82b624a

Parents:

25b14be

Message:

eliminated some redundancy and exchanged CONTROL2 with the config-filename

Location:

source/python

Files:

• classes/ControlFile.py (modified) (1 diff)
• classes/EcFlexpart.py (modified) (5 diffs)
• install.py (modified) (1 diff)
• mods/get_mars_data.py (modified) (1 diff)
• mods/prepare_flexpart.py (modified) (1 diff)
• submit.py (modified) (2 diffs)

source/python/classes/ControlFile.py

@@ -180 +180 @@
 
         # read whole CONTROL file
-        with open(os.path.join(_config.PATH_CONTROLFILES,
-                               self.controlfile)) as f:
-            fdata = f.read().split('\n')
+
+        try:
+            with open(os.path.join(_config.PATH_CONTROLFILES,
+                                   self.controlfile)) as f:
+                fdata = f.read().split('\n')
+        except IOError:
+            print('Could not read CONTROL file "' + args.controlfile + '"')
+            print('Either it does not exist or its syntax is wrong.')
+            print('Try "' + sys.argv[0].split('/')[-1] + \
+                      ' -h" to print usage information')
+            sys.exit(1)
 
         # go through every line and store parameter

source/python/classes/EcFlexpart.py

@@ -807 +807 @@
             over all messages in each grib file which were passed through the
             parameter "inputfiles" to seperate specific parameters into fort.*
-            files. Afterwards the FORTRAN program Convert2 is called to convert
+            files. Afterwards the FORTRAN program is called to convert
             the data fields all to the same grid and put them in one file
             per unique time step (combination of "date", "time" and
@@ -866 +866 @@
             # per date e.g. time = 0, 1200
             # per time e.g. step = 3, 6, 9, 12
-            # flag for Fortran program CONVERT2 and file merging
+            # flag for Fortran program and file merging
             convertFlag = False
             print('current prod: ', prod)
@@ -884 +884 @@
                 # Combine all temporary data files into final grib file if
                 # gid is at least one time not None. Therefore set convertFlag
-                # to save information. The fortran program CONVERT2 is also
-                # only done if convertFlag is True
+                # to save information. The Fortran program is also
+                # only executed if convertFlag is True
                 convertFlag = True
                 # remove old fort.* files and open new ones
@@ -997 +997 @@
                 f.close()
 
-            # call for CONVERT2 if flag is True
+            # call for Fortran program if flag is True
             if convertFlag:
                 pwd = os.getcwd()
@@ -1009 +1009 @@
 
                 # create the corresponding output file fort.15
-                # (generated by CONVERT2) + fort.16 (paramId 167 and 168)
-                p = subprocess.check_call([os.path.join(c.exedir, 'CONVERT2')],
-                                          shell=True)
+                # (generated by Fortran program) + fort.16 (paramId 167 and 168)
+                p = subprocess.check_call([os.path.join(
+                    c.exedir, _config.FORTRAN_EXECUTABLE)], shell=True)
                 os.chdir(pwd)
 

source/python/install.py

@@ -78 +78 @@
     '''
 
-    #os.chdir(_config.PATH_LOCAL_PYTHON)
-
     args = get_install_cmdline_arguments()
-
-    try:
-        c = ControlFile(args.controlfile)
-    except IOError:
-        print('Could not read CONTROL file "' + args.controlfile + '"')
-        print('Either it does not exist or its syntax is wrong.')
-        print('Try "' + sys.argv[0].split('/')[-1] +
-              ' -h" to print usage information')
-        exit(1)
-
+    c = ControlFile(args.controlfile)
     c.assign_args_to_control(args)
     c.check_install_conditions()

source/python/mods/get_mars_data.py

@@ -79 +79 @@
 
     args = get_cmdline_arguments()
-
-    try:
-        c = ControlFile(args.controlfile)
-    except IOError:
-        print('Could not read CONTROL file "' + args.controlfile + '"')
-        print('Either it does not exist or its syntax is wrong.')
-        print('Try "' + sys.argv[0].split('/')[-1] + \
-              ' -h" to print usage information')
-        sys.exit(1)
+    c = ControlFile(args.controlfile)
 
     env_parameter = read_ecenv(_config.PATH_ECMWF_ENV)

source/python/mods/prepare_flexpart.py

@@ -89 +89 @@
 
     args = get_cmdline_arguments()
-
-    try:
-        c = ControlFile(args.controlfile)
-    except IOError:
-        print('Could not read CONTROL file "' + args.controlfile + '"')
-        print('Either it does not exist or its syntax is wrong.')
-        print('Try "' + sys.argv[0].split('/')[-1] + \
-              ' -h" to print usage information')
-        sys.exit(1)
+    c = ControlFile(args.controlfile)
 
     env_parameter = read_ecenv(_config.PATH_ECMWF_ENV)

source/python/submit.py

@@ -77 +77 @@
 
     args = get_cmdline_arguments()
-
-    try:
-        c = ControlFile(args.controlfile)
-    except IOError:
-        print('Could not read CONTROL file "' + args.controlfile + '"')
-        print('Either it does not exist or its syntax is wrong.')
-        print('Try "' + sys.argv[0].split('/')[-1] + \
-              ' -h" to print usage information')
-        sys.exit(1)
+    c = ControlFile(args.controlfile)
 
     env_parameter = read_ecenv(_config.PATH_ECMWF_ENV)
@@ -95 +87 @@
     # on ECMWF server this would also be the local side
     called_from_dir = os.getcwd()
-    if args.queue is None:
+    if not args.queue:
         if c.inputdir[0] != '/':
             c.inputdir = os.path.join(called_from_dir, c.inputdir)